Skip to content

Adding interfaces for datascience work - #1

Merged
rchiodo merged 3 commits into
datasciencefrom
dev/rchiodo/add_interfaces
Sep 25, 2018
Merged

Adding interfaces for datascience work#1
rchiodo merged 3 commits into
datasciencefrom
dev/rchiodo/add_interfaces

Conversation

@rchiodo

@rchiodo rchiodo commented Sep 25, 2018

Copy link
Copy Markdown
Owner

Add initial data interfaces for data science work

@rchiodo rchiodo self-assigned this Sep 25, 2018
@rchiodo

rchiodo commented Sep 25, 2018

Copy link
Copy Markdown
Owner Author

@ianhu is added to the review. #Closed

Comment thread src/client/extension.ts
const lintingEngine = serviceManager.get<ILintingEngine>(ILintingEngine);
lintingEngine.linkJupiterExtension(jupyterExtension).ignoreErrors();

// Activate the data science features

@rchiodo rchiodo Sep 25, 2018

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to push your changes before I did mine so my local branch has both of our changes in it. #ByDesign

@rchiodo

rchiodo commented Sep 25, 2018

Copy link
Copy Markdown
Owner Author

@greazer is added to the review. #Closed

@rchiodo
rchiodo merged commit fb9d976 into datascience Sep 25, 2018
@rchiodo
rchiodo deleted the dev/rchiodo/add_interfaces branch September 25, 2018 17:25
rchiodo added a commit that referenced this pull request Sep 26, 2018
* working without inversify

* Working command with service manager

* Initial interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants